pe_output_image_symbols(): rewrite, produce prettier yaml.

1 files changed, 36 insertions, 11 deletions

diff --git a/src/output/pe_output_image_symbols.c b/src/output/pe_output_image_symbols.c
index 408d964..26269ac 100644
--- a/src/output/pe_output_image_symbols.c
+++ b/src/output/pe_output_image_symbols.c
@@ -15,26 +15,51 @@
 #include "perk_dprintf_impl.h"
 #include "perk_errinfo_impl.h"
 
-int pe_output_image_symbols(
+static int pe_output_symbol_names(
 	const struct pe_driver_ctx *	dctx,
-	const struct pe_image_meta *	meta)
+	const struct pe_image_meta *	meta,
+	int                             fdout)
 {
-	int				fdout;
 	struct pe_meta_coff_symbol *	symrec;
-	const char * 			dash = "";
 
-	fdout = pe_driver_fdout(dctx);
-
-	if (dctx->cctx->fmtflags & PERK_PRETTY_YAML) {
-		if (pe_dprintf(fdout,"symbols:\n") < 0)
+	for (symrec=meta->m_symtbl; symrec->cs_name; symrec++)
+		if (pe_dprintf(fdout,"%s\n",symrec->cs_name) < 0)
 			return PERK_FILE_ERROR(dctx);
 
-		dash = "- ";
-	}
+	return 0;
+}
+
+static int pe_output_symbol_names_yaml(
+	const struct pe_driver_ctx *	dctx,
+	const struct pe_image_meta *	meta,
+	int                             fdout)
+{
+	struct pe_meta_coff_symbol *	symrec;
+
+	if (pe_dprintf(fdout,"  - Symbols:\n") < 0)
+		return PERK_FILE_ERROR(dctx);
 
 	for (symrec=meta->m_symtbl; symrec->cs_name; symrec++)
-		if (pe_dprintf(fdout,"%s%s\n",dash,symrec->cs_name) < 0)
+		if (pe_dprintf(fdout,"    - [ symbol: %s ]\n",symrec->cs_name) < 0)
 			return PERK_FILE_ERROR(dctx);
 
 	return 0;
 }
+
+int pe_output_image_symbols(
+	const struct pe_driver_ctx *	dctx,
+	const struct pe_image_meta *	meta)
+{
+	int fdout = pe_driver_fdout(dctx);
+
+	if (dctx->cctx->fmtflags & PERK_PRETTY_YAML) {
+		if (pe_output_symbol_names_yaml(dctx,meta,fdout) < 0)
+			return PERK_NESTED_ERROR(dctx);
+
+	} else {
+		if (pe_output_symbol_names(dctx,meta,fdout) < 0)
+			return PERK_NESTED_ERROR(dctx);
+	}
+
+	return 0;
+}